Skip to content

Uber 555#3572

Merged
haiodo merged 9 commits into
mainfrom
UBER-555
Aug 10, 2023
Merged

Uber 555#3572
haiodo merged 9 commits into
mainfrom
UBER-555

Conversation

@mixerka

@mixerka mixerka commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Screenshot 2023-08-07 at 20 47 11

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@mixerka
mixerka force-pushed the UBER-555 branch 2 times, most recently from 3b64b7f to ce4a067 Compare August 9, 2023 06:55
haiodo
haiodo reviewed Aug 9, 2023
View reviewed changes
Comment thread packages/text-editor/package.json Outdated
haiodo
haiodo reviewed Aug 9, 2023
View reviewed changes
Comment thread packages/text-editor/src/components/StyledTextEditor.svelte Outdated
mixerka added 8 commits August 10, 2023 10:53
@mixerka
UBER-555: Move editor toolbar to a bubble
5240525 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-555: Fix the case with one line text
724badd 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-555: Fix lock
d5b78f6 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-555: Put back first toolbar, move another one toolbar into the b…
a878d35 
…ubble

Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-555: Fix format
aeb1f2a 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-555: Fix component default value
176e32a 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-555: Fix type
3f88c72 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-555: Remove unused code and fix dep version for text editor's bu…
729ba16 
…bble

Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-555: Fix format
f8eacdd 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@haiodo
haiodo merged commit 16d079b into main Aug 10, 2023
@haiodo
haiodo deleted the UBER-555 branch August 10, 2023 16:27
annano pushed a commit that referenced this pull request Aug 24, 2023
@mixerka @annano
Uber 555 (#3572)
fa2c7bf 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
@mixerka
Uber 555 (hcengineering#3572)
5e0f454 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@haiodo haiodo haiodo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mixerka @haiodo