Skip to content

UBER-743: provide person instead of id as prop#3592

Merged
haiodo merged 1 commit into
mainfrom
UBER-743
Aug 16, 2023
Merged

UBER-743: provide person instead of id as prop#3592
haiodo merged 1 commit into
mainfrom
UBER-743

Conversation

@ThetaDR

@ThetaDR ThetaDR commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-743
A list of closed updated issues

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
ThetaDR requested a review from haiodo August 15, 2023 16:11
@haiodo

haiodo commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

@ThetaDR Please also check
image

@haiodo
haiodo merged commit f5c7f54 into main Aug 16, 2023
@haiodo
haiodo deleted the UBER-743 branch August 16, 2023 06:28
annano pushed a commit that referenced this pull request Aug 24, 2023
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants