Skip to content

UBER-749: fix no label for unassigned #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haiodo merged 3 commits into from
Aug 18, 2023
Merged

UBER-749: fix no label for unassigned #3603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
273680a
UBER-749: set default name and show it for headers
ThetaDR Aug 17, 2023
a772d9c
UBER-749: remove status label for placeholder
ThetaDR Aug 17, 2023
019d49e
UBER-749: fix typo
ThetaDR Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/tracker/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ export function createModel (builder: Builder): void {
{
key: 'assignee',
presenter: tracker.component.AssigneeEditor,
displayProps: { key: 'assigee', fixed: 'right' },
displayProps: { key: 'assignee', fixed: 'right' },
props: { kind: 'list', shouldShowName: false, avatarSize: 'x-small' }
}
]
Expand Down
5 changes: 0 additions & 5 deletions plugins/contact-resources/src/components/PersonContent.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,6 @@
<span class="eContentPresenterLabel" class:colorInherit class:fs-bold={accent}>
<Label label={defaultName} />
</span>
{#if statusLabel}
<span class="eContentStatusLabel">
<Label label={statusLabel} />
</span>
{/if}
{/if}
</span>
{/if}
Expand Down
3 changes: 2 additions & 1 deletion plugins/contact-resources/src/components/PersonPresenter.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import PersonContent from './PersonContent.svelte'
import { getClient } from '@hcengineering/presentation'
import { Ref } from '@hcengineering/core'
import ui from '@hcengineering/ui'

export let value: Ref<Person> | Person | null | undefined
export let inline = false
Expand All @@ -28,7 +29,7 @@
export let shouldShowAvatar = true
export let shouldShowName = true
export let shouldShowPlaceholder = false
export let defaultName: IntlString | undefined = undefined
export let defaultName: IntlString | undefined = ui.string.NotSelected
export let statusLabel: IntlString | undefined = undefined
export let tooltipLabels: PersonLabelTooltip | undefined = undefined
export let avatarSize: IconSize = 'x-small'
Expand Down
2 changes: 1 addition & 1 deletion plugins/contact-resources/src/components/PersonRefPresenter.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
export let accent: boolean = false
export let shouldShowAvatar = true
export let shouldShowName = true
export let shouldShowPlaceholder = false
export let shouldShowPlaceholder = true
export let defaultName: IntlString | undefined = undefined
export let tooltipLabels: PersonLabelTooltip | undefined = undefined
export let avatarSize: 'inline' | 'tiny' | 'x-small' | 'small' | 'medium' | 'large' | 'x-large' = 'x-small'
Expand Down