Skip to content

UBER-762: Fix editor popup menu behavior#3617

Merged
BykhovDenis merged 1 commit into
mainfrom
UBER-762
Aug 23, 2023
Merged

UBER-762: Fix editor popup menu behavior#3617
BykhovDenis merged 1 commit into
mainfrom
UBER-762

Conversation

@mixerka

@mixerka mixerka commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Ballon now opens not only on selection, but also on click. This works pretty good because it's a kind of natural behaviour to put cursor somewhere before insert something.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@BykhovDenis
BykhovDenis merged commit 411c194 into main Aug 23, 2023
@BykhovDenis
BykhovDenis deleted the UBER-762 branch August 23, 2023 03:32
annano pushed a commit that referenced this pull request Aug 24, 2023
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants