Skip to content

[UBER-781] Adding chats to inbox after sending messages#3621

Merged
haiodo merged 2 commits into
mainfrom
uber-781-fix-add-dialogs
Aug 23, 2023
Merged

[UBER-781] Adding chats to inbox after sending messages#3621
haiodo merged 2 commits into
mainfrom
uber-781-fix-add-dialogs

Conversation

@sol-0

@sol-0 sol-0 commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/UBER-781

  • changed chat addition - now it's added after a message is sent
  • in case a user has hidden/deleted a chat notification, after sending a message to such chat, it re-appears in the inbox

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@sol-0
sol-0 requested review from BykhovDenis and haiodo August 23, 2023 10:20
Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
@sol-0
sol-0 force-pushed the uber-781-fix-add-dialogs branch from 6a687b7 to 4f60797 Compare August 23, 2023 10:21
@haiodo
haiodo merged commit 04274d1 into main Aug 23, 2023
@haiodo
haiodo deleted the uber-781-fix-add-dialogs branch August 23, 2023 11:24
annano pushed a commit that referenced this pull request Aug 24, 2023
Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
…g#3621)

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants