Skip to content

UBER-798#3628

Merged
haiodo merged 2 commits into
mainfrom
UBER-798
Aug 24, 2023
Merged

UBER-798#3628
haiodo merged 2 commits into
mainfrom
UBER-798

Conversation

@BykhovDenis

@BykhovDenis BykhovDenis commented Aug 24, 2023

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@BykhovDenis
UBER-798
7b9a4cc 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
BykhovDenis requested a review from haiodo August 24, 2023 10:22
@BykhovDenis
Fix tests
ae45c67 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@haiodo
haiodo merged commit 821ed6c into main Aug 24, 2023
@haiodo
haiodo deleted the UBER-798 branch August 24, 2023 15:51
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
@BykhovDenis
UBER-798 (hcengineering#3628)
9aba0ac 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@haiodo haiodo haiodo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BykhovDenis @haiodo