Skip to content

[UBERF-41] Additional chat notification fixes#3633

Merged
sol-0 merged 3 commits into
mainfrom
uberf-41-chat-notif-fixes-2
Aug 25, 2023
Merged

[UBERF-41] Additional chat notification fixes#3633
sol-0 merged 3 commits into
mainfrom
uberf-41-chat-notif-fixes-2

Conversation

@sol-0

@sol-0 sol-0 commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/UBERF-41
Additional fixes for showing "new messages" line

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
@sol-0
sol-0 requested review from BykhovDenis and haiodo August 25, 2023 09:10
@sol-0
sol-0 force-pushed the uberf-41-chat-notif-fixes-2 branch from 8853eed to 2d0ffaf Compare August 25, 2023 09:11
Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
@sol-0
sol-0 merged commit 15cb440 into main Aug 25, 2023
@sol-0
sol-0 deleted the uberf-41-chat-notif-fixes-2 branch August 25, 2023 11:09
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
* [UBERF-41] Additional chat notification fixes

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* [UBERF-41] Reverted a change

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

---------

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants