Skip to content

UBER-810 Split mixin update to doc and mixin#3643

Merged
haiodo merged 2 commits into
mainfrom
uber-810-split-mixin-update
Aug 30, 2023
Merged

UBER-810 Split mixin update to doc and mixin#3643
haiodo merged 2 commits into
mainfrom
uber-810-split-mixin-update

Conversation

@aonnikov

@aonnikov aonnikov commented Aug 30, 2023

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@aonnikov
UBER-810 Split mixin update to doc and mixin
f29eec0 
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
@aonnikov
aonnikov requested review from BykhovDenis and haiodo August 30, 2023 05:45
@aonnikov
aonnikov marked this pull request as draft August 30, 2023 05:45
haiodo
haiodo reviewed Aug 30, 2023
View reviewed changes
Comment thread packages/core/src/operations.ts Outdated
haiodo
haiodo reviewed Aug 30, 2023
View reviewed changes
Comment thread packages/core/src/operations.ts Outdated
haiodo
haiodo reviewed Aug 30, 2023
View reviewed changes
Comment thread packages/core/src/operations.ts Outdated
haiodo
haiodo reviewed Aug 30, 2023
View reviewed changes
Comment thread packages/core/src/operations.ts Outdated
haiodo
haiodo reviewed Aug 30, 2023
View reviewed changes
Comment thread packages/core/tsconfig.json Outdated
@aonnikov
UBER-810 Code review fixes
051ae60 
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
@aonnikov
aonnikov force-pushed the uber-810-split-mixin-update branch from 3cf9e21 to 051ae60 Compare August 30, 2023 13:51
@haiodo
haiodo marked this pull request as ready for review August 30, 2023 14:52
@haiodo
haiodo merged commit e80844e into main Aug 30, 2023
@haiodo
haiodo deleted the uber-810-split-mixin-update branch August 30, 2023 16:44
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
@aonnikov
UBER-810 Split mixin update to doc and mixin (hcengineering#3643)
7726dc3 
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis
1 more reviewer
@haiodo haiodo haiodo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aonnikov @haiodo