Skip to content

fix: trim cookie string before extracting values#3652

Merged
haiodo merged 1 commit into
mainfrom
fix-files-api
Sep 1, 2023
Merged

fix: trim cookie string before extracting values#3652
haiodo merged 1 commit into
mainfrom
fix-files-api

Conversation

@aonnikov

@aonnikov aonnikov commented Sep 1, 2023

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

Files API has been broken doe to cookie changes.
Cookies are separated by ; in a cookie string, so due to extra whitespace in the cookie name, the token was not parsed properly.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
@haiodo
haiodo merged commit 25514b5 into main Sep 1, 2023
@haiodo
haiodo deleted the fix-files-api branch September 1, 2023 11:41
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants