Skip to content

Collaborator Text Editor: add node highlight extension for inline comments feature#3660

Merged
annano merged 3 commits into
mainfrom
ano/node-highlighr-extension-for-inline-comments
Sep 6, 2023
Merged

Collaborator Text Editor: add node highlight extension for inline comments feature#3660
annano merged 3 commits into
mainfrom
ano/node-highlighr-extension-for-inline-comments

Conversation

@annano

@annano annano commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

  • add extension to add node-uuid attribute to selected text
  • add extension to add highlights for particular nodes
  • add support for additional style panel actions to configure adding inline comments

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Comment thread packages/text-editor/src/components/CollaboratorEditor.svelte Outdated
…ments feature

Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
@annano
annano force-pushed the ano/node-highlighr-extension-for-inline-comments branch from 022b918 to 8a4fe18 Compare September 6, 2023 08:06
@annano
annano merged commit 7c2aa9f into main Sep 6, 2023
@annano
annano deleted the ano/node-highlighr-extension-for-inline-comments branch September 6, 2023 09:01
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
…ments feature (hcengineering#3660)

* Collaborator Text Editor: add node highlight extension for inline comments feature

Signed-off-by: Anna No <anna.no@xored.com>

* fix dependencies

Signed-off-by: Anna No <anna.no@xored.com>

* use generateId instead of uuid

Signed-off-by: Anna No <anna.no@xored.com>

---------

Signed-off-by: Anna No <anna.no@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants