[UBER-829] Avoiding redundant table model rebuilding#3668
Merged
Conversation
Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
Contributor
|
@sol-0 why we need to restore scroll position? if we show panel on top of all content, it should be not touched. So please check a bit more. |
Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
sol-0
force-pushed
the
uber-829-fix-scroll-restoration
branch
from
September 11, 2023 12:13
6b0d32f to
d11699b
Compare
Contributor
Author
I've looked for root cause once again and found out that table model was rebuilding every time that caused table re-rendering. Now we're caching the results and checking the changes in model options before rebuilding the model. |
haiodo
approved these changes
Sep 11, 2023
BykhovDenis
approved these changes
Sep 11, 2023
MichaelUray
pushed a commit
to MichaelUray/huly-platform
that referenced
this pull request
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Brief description
https://front.hc.engineering/workbench/platform/tracker/UBER-829
Tableto avoid model rebuilding and re-renderingChecklist
Related issues
A list of closed updated issues