Skip to content

[UBER-829] Avoiding redundant table model rebuilding#3668

Merged
BykhovDenis merged 2 commits into
mainfrom
uber-829-fix-scroll-restoration
Sep 11, 2023
Merged

[UBER-829] Avoiding redundant table model rebuilding#3668
BykhovDenis merged 2 commits into
mainfrom
uber-829-fix-scroll-restoration

Conversation

@sol-0

@sol-0 sol-0 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/UBER-829

  • caching model options in Table to avoid model rebuilding and re-rendering

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
@sol-0
sol-0 requested review from BykhovDenis and haiodo September 7, 2023 15:46
@sol-0 sol-0 changed the title [UBER-829] Fix scroll position restoration [UBER-829] Scroll position restoration fix Sep 7, 2023
@haiodo

haiodo commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

@sol-0 why we need to restore scroll position? if we show panel on top of all content, it should be not touched. So please check a bit more.

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
@sol-0
sol-0 force-pushed the uber-829-fix-scroll-restoration branch from 6b0d32f to d11699b Compare September 11, 2023 12:13
@sol-0 sol-0 changed the title [UBER-829] Scroll position restoration fix [UBER-829] Avoiding redundant table model rebuilding Sep 11, 2023
@sol-0

sol-0 commented Sep 11, 2023

Copy link
Copy Markdown
Contributor Author

@sol-0 why we need to restore scroll position? if we show panel on top of all content, it should be not touched. So please check a bit more.

I've looked for root cause once again and found out that table model was rebuilding every time that caused table re-rendering. Now we're caching the results and checking the changes in model options before rebuilding the model.

@BykhovDenis
BykhovDenis merged commit 153cbe6 into main Sep 11, 2023
@BykhovDenis
BykhovDenis deleted the uber-829-fix-scroll-restoration branch September 11, 2023 15:45
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
)

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants