Skip to content

UBER-839: request the category if it's not in lookup#3679

Merged
haiodo merged 3 commits into
mainfrom
UBER-839
Sep 12, 2023
Merged

UBER-839: request the category if it's not in lookup#3679
haiodo merged 3 commits into
mainfrom
UBER-839

Conversation

@ThetaDR

@ThetaDR ThetaDR commented Sep 11, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

https://front.hc.engineering/workbench/platform/tracker/UBER-839
A list of closed updated issues

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
ThetaDR requested a review from BykhovDenis September 11, 2023 13:55

@BykhovDenis BykhovDenis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need it? (The same logic on next lines)

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR

ThetaDR commented Sep 11, 2023

Copy link
Copy Markdown
Contributor Author

@BykhovDenis sometimes value.category is undefined and the category is stored in status

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo
haiodo merged commit 709164c into main Sep 12, 2023
@haiodo
haiodo deleted the UBER-839 branch September 12, 2023 05:27
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
)

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants