Skip to content

UBER-880 Use space presenter for starred spaces#3717

Merged
haiodo merged 1 commit into
mainfrom
UBER-880-star-space-presenter
Sep 19, 2023
Merged

UBER-880 Use space presenter for starred spaces#3717
haiodo merged 1 commit into
mainfrom
UBER-880-star-space-presenter

Conversation

@aonnikov

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

Follow up for space starring fix. We should use the same space presenter for both starred and not starred spaces. Otherwise, starred spaces will be unusable.

Before:
Screenshot 2023-09-19 at 23 26 05
After:
Screenshot 2023-09-19 at 23 26 23

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
@haiodo
haiodo merged commit fd54365 into main Sep 19, 2023
@haiodo
haiodo deleted the UBER-880-star-space-presenter branch September 19, 2023 17:21
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants