Skip to content

UBER-845: Add NotificationPresenter to send rich text notifications#3729

Merged
haiodo merged 14 commits into
mainfrom
UBER-845
Sep 28, 2023
Merged

UBER-845: Add NotificationPresenter to send rich text notifications#3729
haiodo merged 14 commits into
mainfrom
UBER-845

Conversation

@mixerka

@mixerka mixerka commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@mixerka
mixerka requested a review from BykhovDenis September 22, 2023 05:30
haiodo
haiodo reviewed Sep 22, 2023
View reviewed changes
Comment thread packages/text/src/plain-text.ts Outdated
haiodo
haiodo reviewed Sep 22, 2023
View reviewed changes
Comment thread plugins/notification/src/index.ts
haiodo
haiodo reviewed Sep 22, 2023
View reviewed changes
Comment thread plugins/notification/src/index.ts
haiodo
haiodo reviewed Sep 22, 2023
View reviewed changes
Comment thread plugins/notification/src/index.ts
haiodo
haiodo reviewed Sep 22, 2023
View reviewed changes
Comment thread server-plugins/notification-resources/src/index.ts Outdated
haiodo
haiodo reviewed Sep 22, 2023
View reviewed changes
Comment thread server-plugins/notification/src/index.ts Outdated
haiodo
haiodo reviewed Sep 22, 2023
View reviewed changes
Comment thread server-plugins/tracker-resources/src/index.ts Outdated
haiodo
haiodo reviewed Sep 22, 2023
View reviewed changes
Comment thread server-plugins/tracker-resources/src/index.ts
aonnikov
aonnikov reviewed Sep 22, 2023
View reviewed changes
Comment thread server-plugins/chunter-resources/src/index.ts Outdated
Comment thread plugins/notification/src/index.ts Outdated
Comment thread plugins/notification/src/index.ts
@mixerka
UBER-845: Add NotificationPresenter to send rich text notifications
15ccc9a 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Fix formaty
97c3d66 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Fix format 2
6f1cbcd 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Add license comment
26b3ceb 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Fix format 3
49acce9 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Handle params which need to be lozalized too
d09f2d2 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Fix format 4
87d517a 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Fix translations
5c2c011 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Fix not localized params
676ee54 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Fix shrinkwrap
89268f2 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Renaming things
dba1eaf 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Change strip html tags implementation from SAX to Prosemirr…
7afc655 
…or model

Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka
UBER-845: Fix format
f2e7a61 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
haiodo
haiodo reviewed Sep 26, 2023
View reviewed changes
Comment thread packages/text/src/html.ts
@mixerka
UBER-845: Prefer undefined
6a29a23 
Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
@mixerka

mixerka commented Sep 26, 2023

Copy link
Copy Markdown
Contributor Author

So seems that I've fixed all issues with the code is there anything I still need to fix?

@haiodo
haiodo merged commit 1ca9de2 into main Sep 28, 2023
@haiodo
haiodo deleted the UBER-845 branch September 28, 2023 05:08
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
@mixerka
UBER-845: Add NotificationPresenter to send rich text notifications (h…
4cc4b6b 
…cengineering#3729)

Signed-off-by: Maxim Karmatskikh <mkarmatskih@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aonnikov aonnikov aonnikov left review comments
@BykhovDenis BykhovDenis BykhovDenis approved these changes
+1 more reviewer
@haiodo haiodo haiodo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mixerka @haiodo @aonnikov @BykhovDenis