Skip to content

Add isEmpty extension to remove on:content event from collaborator editor#3774

Merged
annano merged 7 commits into
mainfrom
ano/add-validation-extension
Oct 2, 2023
Merged

Add isEmpty extension to remove on:content event from collaborator editor#3774
annano merged 7 commits into
mainfrom
ano/add-validation-extension

Conversation

@annano

@annano annano commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

… editor

Signed-off-by: Anna No <anna.no@xored.com>
… editor

Signed-off-by: Anna No <anna.no@xored.com>
Comment thread packages/text-editor/src/components/extension/validateContent.ts Outdated
Comment thread packages/text-editor/src/components/extension/validateContent.ts Outdated
Comment thread packages/text-editor/src/components/extension/validateContent.ts Outdated
… editor

Signed-off-by: Anna No <anna.no@xored.com>
@annano
annano requested a review from aonnikov October 2, 2023 13:36
…itor

Signed-off-by: Anna No <anna.no@xored.com>
@annano annano changed the title Add validation extension to remove on:content event Add isEmpty extension to remove on:content event from collaborator editor Oct 2, 2023
annano added 3 commits October 2, 2023 21:15
…itor

Signed-off-by: Anna No <anna.no@xored.com>
…itor

Signed-off-by: Anna No <anna.no@xored.com>
…itor

Signed-off-by: Anna No <anna.no@xored.com>
@annano
annano merged commit 152c858 into main Oct 2, 2023
@annano
annano deleted the ano/add-validation-extension branch October 2, 2023 15:18
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
…itor (hcengineering#3774)

* Add validation extension to remove on content event from collaborator editor

Signed-off-by: Anna No <anna.no@xored.com>

* Add validation extension to remove on content event from collaborator editor

Signed-off-by: Anna No <anna.no@xored.com>

* Add validation extension to remove on content event from collaborator editor

Signed-off-by: Anna No <anna.no@xored.com>

* Add isEmpty extension to remove on:content event from collaborator editor

Signed-off-by: Anna No <anna.no@xored.com>

* Add isEmpty extension to remove on:content event from collaborator editor

Signed-off-by: Anna No <anna.no@xored.com>

* Add isEmpty extension to remove on:content event from collaborator editor

Signed-off-by: Anna No <anna.no@xored.com>

* Add isEmpty extension to remove on:content event from collaborator editor

Signed-off-by: Anna No <anna.no@xored.com>

---------

Signed-off-by: Anna No <anna.no@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants