Skip to content

Adjust reference input styles#3816

Merged
aonnikov merged 4 commits into
mainfrom
ano/adjust-styled-for-reference-input
Oct 10, 2023
Merged

Adjust reference input styles#3816
aonnikov merged 4 commits into
mainfrom
ano/adjust-styled-for-reference-input

Conversation

@annano

@annano annano commented Oct 9, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Screenshot from 2023-10-09 20-30-25

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@annano
annano requested review from aonnikov and lexiv0re October 9, 2023 13:34
lexiv0re
lexiv0re reviewed Oct 9, 2023
View reviewed changes
Comment thread packages/text-editor/src/components/ReferenceInput.svelte
Comment thread packages/text-editor/src/components/ReferenceInput.svelte Outdated
Comment thread packages/text-editor/src/components/StyledTextEditor.svelte Outdated
Comment thread packages/text-editor/src/components/StyledTextEditor.svelte Outdated
Comment thread packages/text-editor/src/components/ReferenceInput.svelte
aonnikov
aonnikov reviewed Oct 9, 2023
View reviewed changes
Comment thread packages/text-editor/src/components/ReferenceInput.svelte Outdated
Comment thread packages/text-editor/src/components/ReferenceInput.svelte
Comment thread packages/text-editor/src/components/ReferenceInput.svelte Outdated
annano added 2 commits October 10, 2023 12:38
@annano
adjust reference input styles
59978aa 
Signed-off-by: Anna No <anna.no@xored.com>
@annano
update text editors styles
daeeb7e 
Signed-off-by: Anna No <anna.no@xored.com>
@annano
annano force-pushed the ano/adjust-styled-for-reference-input branch from 783c045 to daeeb7e Compare October 10, 2023 05:38
@annano
address review comments
dc8c5ba 
Signed-off-by: Anna No <anna.no@xored.com>
@annano
annano requested review from aonnikov and lexiv0re October 10, 2023 06:18
@annano
fix ui tests
ed8581e 
Signed-off-by: Anna No <anna.no@xored.com>
@aonnikov
aonnikov merged commit 84d8141 into main Oct 10, 2023
@aonnikov
aonnikov deleted the ano/adjust-styled-for-reference-input branch October 10, 2023 16:34
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
@annano
Adjust reference input styles (hcengineering#3816)
7dc7d2a 
Signed-off-by: Anna No <anna.no@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aonnikov aonnikov aonnikov approved these changes
@lexiv0re lexiv0re lexiv0re approved these changes

Assignees

@aonnikov aonnikov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@annano @aonnikov @lexiv0re