Skip to content

UBER-1028 Improve list / sublist editing#3830

Merged
haiodo merged 2 commits into
mainfrom
uber-1028-sublist-editing
Oct 12, 2023
Merged

UBER-1028 Improve list / sublist editing#3830
haiodo merged 2 commits into
mainfrom
uber-1028-sublist-editing

Conversation

@aonnikov

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

  1. Use extension-list-keymap for better command handling in lists. See Backspace does not work properly ueberdosis/tiptap#3367
  2. Lock focus inside editor so it does not leak to other components when typing

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@aonnikov
aonnikov requested review from annano and haiodo October 12, 2023 05:36
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
@aonnikov
aonnikov force-pushed the uber-1028-sublist-editing branch from c4830f4 to dcbf4fb Compare October 12, 2023 05:52
@haiodo
haiodo merged commit 0a822d1 into main Oct 12, 2023
@haiodo
haiodo deleted the uber-1028-sublist-editing branch October 12, 2023 09:25
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants