Skip to content

UBER-1052: Fix remainings#3844

Merged
haiodo merged 2 commits into
mainfrom
UBER-1052
Oct 16, 2023
Merged

UBER-1052: Fix remainings#3844
haiodo merged 2 commits into
mainfrom
UBER-1052

Conversation

@haiodo

@haiodo haiodo commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo
UBER-1052: Fix remainings
d635945 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
haiodo requested a review from BykhovDenis October 16, 2023 12:20
@haiodo
Fix formatting
b4c38b5 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
haiodo merged commit 3c0ff4c into main Oct 16, 2023
@haiodo
haiodo deleted the UBER-1052 branch October 16, 2023 16:02
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
@haiodo
UBER-1052: Fix remainings (hcengineering#3844)
3848813 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haiodo @BykhovDenis