Skip to content

feat(tests): added page-object model example. Refactor login test to page-object model. Added a new test channel.spec.ts#3847

Merged
nestoragent merged 6 commits into
mainfrom
feat/addedChannelTestSigned
Oct 17, 2023
Merged

feat(tests): added page-object model example. Refactor login test to page-object model. Added a new test channel.spec.ts#3847
nestoragent merged 6 commits into
mainfrom
feat/addedChannelTestSigned

Conversation

@nestoragent

@nestoragent nestoragent commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

feat(tests): added page-object model example. Refactor login test to page-object model. Added a new test channel.spec.ts

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@nestoragent nestoragent changed the title feat(test): fixed spelling feat(tests): added page-object model example. Refactor login test to page-object model. Added a new test channel.spec.ts Oct 16, 2023
@nestoragent
nestoragent requested a review from haiodo October 16, 2023 18:19
@haiodo

haiodo commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

@nestoragent Please sign with GPG (-s -S keys for git console)

@nestoragent

Copy link
Copy Markdown
Contributor Author

@nestoragent Please sign with GPG (-s -S keys for git console)

Thank you.
Used Sign-off commit i WebStorm and looks like it didn't work =(
Снимок экрана 2023-10-17 в 10 34 30

Will do in console now

Signed-off-by: Alex Velichko <nestor_007@mail.ru>
…page-object model. Added a new test channel.spec.ts

Signed-off-by: Alex Velichko <nestor_007@mail.ru>
Signed-off-by: Alex Velichko <nestor_007@mail.ru>
Signed-off-by: Alex Velichko <nestor_007@mail.ru>
Signed-off-by: Alex Velichko <nestor_007@mail.ru>
Signed-off-by: Alex Velichko <nestor_007@mail.ru>
@nestoragent
nestoragent force-pushed the feat/addedChannelTestSigned branch from b77c09b to b765cc1 Compare October 17, 2023 09:21
@nestoragent
nestoragent merged commit 0d1ba6a into main Oct 17, 2023
@haiodo
haiodo deleted the feat/addedChannelTestSigned branch October 17, 2023 14:42
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
…page-object model. Added a new test channel.spec.ts (hcengineering#3847)

* feat(tests): added page-object model example. Refactor login test to page-object model. Added a new test channel.spec.ts
---------

Signed-off-by: Alex Velichko <nestor_007@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants