Skip to content

TSK-1660 Get rid of ListSelectionProvider.Pop#3879

Merged
haiodo merged 1 commit into
mainfrom
tsk-1660-provider-pop
Oct 24, 2023
Merged

TSK-1660 Get rid of ListSelectionProvider.Pop#3879
haiodo merged 1 commit into
mainfrom
tsk-1660-provider-pop

Conversation

@aonnikov

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

This PR fixes bug with destroying wrong selection provider when closing a child issue.

This approach is buggy and does not properly work now:

  1. it is used in kanban only for up/down navigation by subissues, in list we use different approach
  2. Up/down navigation uses the "current" provider that is the latest created provider, not necessary this one, it breaks when opened issue has subissues
  3. ListSelectionProvider.Pop removes the top provider, that is not necessary the created one. We pop it in different place so cannot be sure what the proper provider has been destroyed.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
@haiodo
haiodo merged commit 2363aed into main Oct 24, 2023
@haiodo
haiodo deleted the tsk-1660-provider-pop branch October 24, 2023 15:24
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants