Skip to content

UBER-1053#3884

Merged
haiodo merged 5 commits into
mainfrom
UBER-1053
Oct 27, 2023
Merged

UBER-1053#3884
haiodo merged 5 commits into
mainfrom
UBER-1053

Conversation

@BykhovDenis

@BykhovDenis BykhovDenis commented Oct 25, 2023

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@BykhovDenis
BykhovDenis requested a review from haiodo October 25, 2023 06:32
@BykhovDenis BykhovDenis self-assigned this Oct 25, 2023
@BykhovDenis
BykhovDenis marked this pull request as draft October 25, 2023 18:07
@BykhovDenis
BykhovDenis marked this pull request as ready for review October 26, 2023 15:14
haiodo
haiodo reviewed Oct 26, 2023
View reviewed changes
Comment thread plugins/view-resources/src/components/TableBrowser.svelte Outdated
haiodo
haiodo previously approved these changes Oct 26, 2023
View reviewed changes
@BykhovDenis
BykhovDenis force-pushed the UBER-1053 branch 3 times, most recently from 175d92c to 4108785 Compare October 26, 2023 17:50
@BykhovDenis
UBER-1053
07aec17 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Fixes
2552418 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Fixes
37f2d8c 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Fix migration
18a9979 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
Remove extra log
ee376d7 
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@haiodo
haiodo merged commit 156741c into main Oct 27, 2023
@haiodo
haiodo deleted the UBER-1053 branch October 27, 2023 05:22
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
@BykhovDenis
UBER-1053 (hcengineering#3884)
0db110f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@haiodo haiodo haiodo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BykhovDenis BykhovDenis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BykhovDenis @haiodo