Skip to content

UBER-1118 Wiki images improvements#3887

Merged
haiodo merged 5 commits into
mainfrom
uber-1118-wiki-images
Oct 25, 2023
Merged

UBER-1118 Wiki images improvements#3887
haiodo merged 5 commits into
mainfrom
uber-1118-wiki-images

Conversation

@aonnikov

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

  1. Set default image width to 100% and left alignment
  2. Open image fullscreen on double click
  3. Solve toolbar z-index issue
  4. Do not show text style toolbar when clicking on an image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
@aonnikov
aonnikov requested review from annano and haiodo October 25, 2023 14:42
@haiodo
haiodo merged commit f64901c into main Oct 25, 2023
@haiodo
haiodo deleted the uber-1118-wiki-images branch October 25, 2023 16:13
BykhovDenis pushed a commit that referenced this pull request Oct 26, 2023
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants