Skip to content

fix for mixins for grouping by custom attributes#3898

Merged
haiodo merged 2 commits into
mainfrom
custom_attr_groupBy
Oct 29, 2023
Merged

fix for mixins for grouping by custom attributes#3898
haiodo merged 2 commits into
mainfrom
custom_attr_groupBy

Conversation

@ThetaDR

@ThetaDR ThetaDR commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
ThetaDR requested a review from haiodo October 26, 2023 17:11
@ThetaDR ThetaDR self-assigned this Oct 26, 2023
Comment thread plugins/view-resources/src/components/ViewOptionsButton.svelte Outdated
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo
haiodo merged commit e158788 into main Oct 29, 2023
@haiodo
haiodo deleted the custom_attr_groupBy branch October 29, 2023 17:23
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants