Skip to content

[MINOR] QMS: fix collaborator editor loading#3920

Merged
annano merged 1 commit into
mainfrom
ano/minor-fix-qms-collaborator-editor
Oct 31, 2023
Merged

[MINOR] QMS: fix collaborator editor loading#3920
annano merged 1 commit into
mainfrom
ano/minor-fix-qms-collaborator-editor

Conversation

@annano

@annano annano commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Anna No <anna.no@xored.com>
Comment thread packages/text-editor/src/components/CollaboratorEditor.svelte

@sol-0 sol-0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aonnikov @annano Do we also need to wait for synced from contextProvider?

@annano
annano merged commit 5dede58 into main Oct 31, 2023
@annano
annano deleted the ano/minor-fix-qms-collaborator-editor branch October 31, 2023 08:07
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Anna No <anna.no@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants