Skip to content

UBERF-4195: fix query after applying viewOptions#3942

Merged
haiodo merged 5 commits into
mainfrom
UBERF-4195
Nov 10, 2023
Merged

UBERF-4195: fix query after applying viewOptions#3942
haiodo merged 5 commits into
mainfrom
UBERF-4195

Conversation

@ThetaDR

@ThetaDR ThetaDR commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR
ThetaDR requested a review from haiodo November 6, 2023 12:48

@BykhovDenis BykhovDenis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break viewOptions, can you give an example? (If it necessary we should find another way to fix it, probably we need method in core to merge queries)

@ThetaDR

ThetaDR commented Nov 6, 2023

Copy link
Copy Markdown
Contributor Author

@BykhovDenis long story short. It replaces spaces that we are using in filter with spaces from viewOptions (for non-archive)

More info:

  1. Company1 has two vacancies (vac1 and vac2)
    Company2 has vac3
  2. All of them have applicants
  3. Vac1 is archived
  4. User is trying to filter applicants via vacancy with company == Company1. And viewOption for hiding archived vacancies is on.

So it will override spaces (vac1 and vac2) with spaces that are not archived (vac1 and vac3)

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR

ThetaDR commented Nov 7, 2023

Copy link
Copy Markdown
Contributor Author

@BykhovDenis PTAL, made a function for queries merging

Comment thread packages/core/src/utils.ts Outdated
…redicate

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
ThetaDR requested a review from haiodo November 8, 2023 11:49
Comment thread plugins/task-resources/src/components/kanban/KanbanView.svelte
Comment thread plugins/view-resources/src/components/list/List.svelte
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Comment thread packages/core/src/utils.ts Outdated
Comment thread packages/core/src/utils.ts
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo
haiodo merged commit f8cdaba into main Nov 10, 2023
@haiodo
haiodo deleted the UBERF-4195 branch November 10, 2023 07:09
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants