UBERF-4195: fix query after applying viewOptions#3942
Merged
Conversation
BykhovDenis
requested changes
Nov 6, 2023
BykhovDenis
left a comment
Member
There was a problem hiding this comment.
This will break viewOptions, can you give an example? (If it necessary we should find another way to fix it, probably we need method in core to merge queries)
Contributor
Author
|
@BykhovDenis long story short. It replaces spaces that we are using in filter with spaces from viewOptions (for non-archive) More info:
So it will override spaces (vac1 and vac2) with spaces that are not archived (vac1 and vac3) |
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Contributor
Author
|
@BykhovDenis PTAL, made a function for queries merging |
haiodo
reviewed
Nov 8, 2023
…redicate Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
haiodo
reviewed
Nov 8, 2023
haiodo
reviewed
Nov 8, 2023
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
haiodo
reviewed
Nov 8, 2023
haiodo
reviewed
Nov 8, 2023
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
haiodo
approved these changes
Nov 10, 2023
BykhovDenis
approved these changes
Nov 10, 2023
MichaelUray
pushed a commit
to MichaelUray/huly-platform
that referenced
this pull request
Jul 9, 2026
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Brief description
Checklist
Related issues
A list of closed updated issues