Skip to content

EZQMS-360: Platform changes for document comments highlight sync#3965

Merged
annano merged 2 commits into
mainfrom
ano/EZQMS-360/sync-comments-highlight
Nov 9, 2023
Merged

EZQMS-360: Platform changes for document comments highlight sync#3965
annano merged 2 commits into
mainfrom
ano/EZQMS-360/sync-comments-highlight

Conversation

@annano

@annano annano commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
@aonnikov

aonnikov commented Nov 9, 2023

Copy link
Copy Markdown
Member

Not for this PR, but I think that we need to expose selectRange and selectNode as editor commands, not just exported functions in component.

@annano
annano merged commit 67a563d into main Nov 9, 2023
@annano
annano deleted the ano/EZQMS-360/sync-comments-highlight branch November 9, 2023 14:53
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
…ngineering#3965)

* EZQMS-360: Platform changes for document comments highlight sync

Signed-off-by: Anna No <anna.no@xored.com>

* EZQMS-360: Platform changes for document comments highlight sync

Signed-off-by: Anna No <anna.no@xored.com>

---------

Signed-off-by: Anna No <anna.no@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants