Skip to content

UBERF-4895: Fix closing issue panel from custom issue list pages#4468

Merged
haiodo merged 1 commit into
mainfrom
uberf-4895
Jan 30, 2024
Merged

UBERF-4895: Fix closing issue panel from custom issue list pages#4468
haiodo merged 1 commit into
mainfrom
uberf-4895

Conversation

@d-uzlov

@d-uzlov d-uzlov commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

In Workbench.mergeLoc checking loc.path[3] === resolved.defaultLocation.path[3] has a false positive when currentSpace === resolved.defaultLocation.path[3], resulting in location address being overwritten by default location when opening issue page.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Signed-off-by: Danil Uzlov <danil.uzlov@xored.com>
@d-uzlov
d-uzlov requested review from BykhovDenis and haiodo January 29, 2024 10:51
@haiodo
haiodo merged commit 2ba02fa into main Jan 30, 2024
@haiodo
haiodo deleted the uberf-4895 branch January 30, 2024 08:05
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
)

Signed-off-by: Danil Uzlov <danil.uzlov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants