Skip to content

UBERF-5337#4548

Merged
haiodo merged 2 commits into
mainfrom
UBERF-5337
Feb 7, 2024
Merged

UBERF-5337#4548
haiodo merged 2 commits into
mainfrom
UBERF-5337

Conversation

@BykhovDenis

@BykhovDenis BykhovDenis commented Feb 6, 2024

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@BykhovDenis
BykhovDenis requested a review from haiodo February 6, 2024 10:04
@BykhovDenis BykhovDenis self-assigned this Feb 6, 2024
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
@haiodo
haiodo merged commit 169a83c into main Feb 7, 2024
@haiodo
haiodo deleted the UBERF-5337 branch February 7, 2024 09:22
@BykhovDenis
BykhovDenis restored the UBERF-5337 branch February 7, 2024 16:57
@BykhovDenis
BykhovDenis deleted the UBERF-5337 branch February 7, 2024 17:42
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants