Skip to content

EZQMS-563: Moved ActionWithAvailability helper type and functions from questions to view#4611

Merged
BykhovDenis merged 2 commits into
mainfrom
EZQMS-563
Feb 14, 2024
Merged

EZQMS-563: Moved ActionWithAvailability helper type and functions from questions to view#4611
BykhovDenis merged 2 commits into
mainfrom
EZQMS-563

Conversation

@anotherpit

@anotherpit anotherpit commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

Contribution checklist

Brief description

Tiny abstraction around View Action to keep action availability function and action handler function together. Introduced, tested and proved in questions and training plugins.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

…rom `questions` to `view`

Signed-off-by: Petr Vyazovetskiy <develop.pit@gmail.com>
Comment thread plugins/view/src/types.ts Outdated
Comment thread plugins/view/src/types.ts
Signed-off-by: Petr Vyazovetskiy <develop.pit@gmail.com>
@anotherpit
anotherpit requested a review from haiodo February 13, 2024 16:57
@BykhovDenis
BykhovDenis merged commit 22093e7 into main Feb 14, 2024
@BykhovDenis
BykhovDenis deleted the EZQMS-563 branch February 14, 2024 13:52
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
…rom `questions` to `view` (hcengineering#4611)

Signed-off-by: Petr Vyazovetskiy <develop.pit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants