Skip to content

Fix chat scrolling to new messages#4615

Merged
haiodo merged 1 commit into
fix-new-marker-5323from
fix-chat-scroll
Feb 13, 2024
Merged

Fix chat scrolling to new messages#4615
haiodo merged 1 commit into
fix-new-marker-5323from
fix-chat-scroll

Conversation

@kristina-fefelova

@kristina-fefelova kristina-fefelova commented Feb 13, 2024

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova

Copy link
Copy Markdown
Member Author
  1. if user sent a message and user is at the bottom of the chat - scroll down to show the new message
  2. if user received a message and user is at the bottom of the chat - scroll down to show the new message

@haiodo
haiodo merged commit 8f29c05 into fix-new-marker-5323 Feb 13, 2024
@haiodo
haiodo deleted the fix-chat-scroll branch February 13, 2024 15:33
kristina-fefelova added a commit that referenced this pull request Feb 14, 2024
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
haiodo pushed a commit that referenced this pull request Feb 14, 2024
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
…g#4633)

Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants