Skip to content

Improve chat loading#4627

Merged
haiodo merged 1 commit into
mainfrom
chat-loading
Feb 14, 2024
Merged

Improve chat loading#4627
haiodo merged 1 commit into
mainfrom
chat-loading

Conversation

@kristina-fefelova

@kristina-fefelova kristina-fefelova commented Feb 14, 2024

Copy link
Copy Markdown
Member

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@kristina-fefelova

Copy link
Copy Markdown
Member Author

Added some fixes:

  • load attachments with messages to avoid additional loading
  • reserve space for reactions and replies if they present to avoid height change
  • reserve space for attachments card (for activity)
  • dont use show more in chat for chat messages
  • hide chat aside by default

@haiodo
haiodo merged commit d23b9ee into main Feb 14, 2024
@haiodo
haiodo deleted the chat-loading branch February 14, 2024 09:09
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants