ci: Add OS and libc compatibility CI for musl Linux and FreeBSD#291
Merged
Conversation
Introduce a new CI workflow to ensure portability across different operating systems and libc implementations. This workflow specifically targets: - **musl libc (Alpine Linux):** Catches non-glibc specific issues, such as differences in default thread stack size. - **FreeBSD:** Acts as a portability canary for non-glibc and clang environments, relevant for BSD packaging. Both environments run the full `STATIC+SHARED` ctest suite with `ZXC_NATIVE_ARCH=OFF` to validate broader runtime compatibility.
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
The review identifies a critical gap: while the PR title and intent specify the addition of CI workflows for musl Linux and FreeBSD, no files were modified or added in this submission.
Consequently, none of the acceptance criteria—such as configuring Alpine/FreeBSD environments or setting specific build flags like ZXC_NATIVE_ARCH=OFF—have been met. The PR cannot be evaluated for quality or correctness in its current state.
About this PR
- The Pull Request title and description indicate significant changes to the CI infrastructure (Alpine Linux/musl and FreeBSD support), yet no files appear to have been modified or added in this submission. Please ensure the relevant workflow files are included in the branch.
Test suggestions
- Verify CI configuration for Alpine Linux (musl) is correctly defined
- Verify CI configuration for FreeBSD is correctly defined
- Verify ctest execution includes STATIC and SHARED configurations
- Verify ZXC_NATIVE_ARCH is set to OFF in CI scripts
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify CI configuration for Alpine Linux (musl) is correctly defined
2. Verify CI configuration for FreeBSD is correctly defined
3. Verify ctest execution includes STATIC and SHARED configurations
4. Verify ZXC_NATIVE_ARCH is set to OFF in CI scripts
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new CI workflow to ensure portability across different operating systems and libc implementations.
This workflow specifically targets:
Both environments run the full
STATIC+SHAREDctest suite withZXC_NATIVE_ARCH=OFFto validate broader runtime compatibility.