fix: Enhances code quality and robustness across components#296
Merged
Conversation
Addresses SonarQube findings related to constructors callable with a single argument that could be implicitly invoked.
Introduces compiler-assisted format string validation for logging functions and extends clang-format rules to the CLI source. Also refactors long lines and adds resource cleanup during dictionary loading, addressing static analysis findings.
Addresses static analysis findings related to explicit function pointer usage and type consistency for sample data buffers.
Consolidates duplicate checks for a closed Seekable object into a private helper method, improving code maintainability and addressing static analysis findings.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses several SonarQube findings to improve overall code quality, type safety, and maintainability.
printf-style format checking attributes to logging functions in the CLI, enabling the compiler to catch format string mismatches at compile time.explicitconstructors in the Node.js wrapper to prevent unintended implicit conversions and refines pointer type handling andconstqualifiers in the CLI, especially during dictionary training, for better correctness.Seekableclass, reducing code duplication. Also adds checks for zero-sized files and memory allocation failures during dictionary training in the CLI.Relates to SonarQube findings