Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] allow clusterIP values to be set empty#20518

Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom
steved:steved/nginx-cluster-ip-empty
Feb 4, 2020
Merged

[stable/nginx-ingress] allow clusterIP values to be set empty#20518
k8s-ci-robot merged 1 commit intohelm:masterfrom
steved:steved/nginx-cluster-ip-empty

Conversation

@steved
Copy link
Copy Markdown
Contributor

@steved steved commented Feb 3, 2020

What this PR does / why we need it:

Helm v2's (have not tested v3) upgrade mechanism is to merge expected values to patch an existing service. This means that the change in the clusterIP field from a v0.x nginx-ingress chart to a v1.x chart caused Helm / Kubernetes to attempt to patch the immutable clusterIP field. Allowing it to be set to an empty string explicitly let's us bypass this diff mechanism and retain the existing clusterIP value.

In Helm 2, it ignored the live state, so it saw no change (old state: clusterIP: "" to new state: clusterIP: ""), and no patch was generated, bypassing this behaviour.

(ref helm/helm#6378 (comment))

Which issue this PR fixes

Special notes for your reviewer:

N/A

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@steved
[stable/nginx-ingress] allow clusterIP values to be set empty
66d631b 
Signed-off-by: Steven Davidovitz <steven.davidovitz@dominodatalab.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 3, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 3, 2020

Hi @steved. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@steved
Copy link
Copy Markdown
Contributor Author

steved commented Feb 3, 2020

/assign @ChiefAlexander

@steved
Copy link
Copy Markdown
Contributor Author

steved commented Feb 3, 2020

Also seems like it'd be possible to go back to this state: #10993. It's a little unclear to me under what conditions we would want to omit the cluster IP entirely (presumably going forward this as the new default?).

@ChiefAlexander
Copy link
Copy Markdown
Contributor

ChiefAlexander commented Feb 3, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2020
@steved
Copy link
Copy Markdown
Contributor Author

steved commented Feb 3, 2020

/retest

@ChiefAlexander
Copy link
Copy Markdown
Contributor

ChiefAlexander commented Feb 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChiefAlexander, steved

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6097dab into helm:master Feb 4, 2020
MarcusSorealheis added a commit to MarcusSorealheis/charts that referenced this pull request Feb 4, 2020
@MarcusSorealheis
Merge branch 'solr_plugin_volume' of github.com:MarcusSorealheis/char…
b4833a0 
…ts into solr_plugin_volume

* 'solr_plugin_volume' of github.com:MarcusSorealheis/charts: (611 commits)
  bump version to be compatible with plugins.
  bump version to be compatible with plugins.
  [stable/kube-state-metrics] Version bump to 1.9.4 (helm#20543)
  [stable/nginx-ingress] allow clusterIP values to be set empty (helm#20518)
  update grafana sidecar to 0.1.75 (helm#20538)
  [stable/mongodb] Release 7.8.2 updating components versions (helm#20537)
  [stable/testlink] add service annotations (helm#20531)
  Rr/strategy (helm#20533)
  [stable/superset] Update Maintainers List (helm#20493)
  [stable/nfs-server-provisioner] New nfs-provisioner with NFSv3 support (helm#19260)
  [stable/pgadmin] removed abundance curly bracket (helm#20530)
  Seq: use deployment strategy (helm#20526)
  [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523)
  [stable/prometheus-redis-exporter] Update image for exporter (helm#19317)
  update alantis version (helm#20507)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517)
  [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409)
  Allow DNS egress to resolve hostnames (helm#20437)
  [stable/rabbitmq] Add PrometheusRule. (helm#20478)
  [stable/drupal] Release 6.2.4 updating components versions (helm#20491)
  ...
lucendio added a commit to wireapp/wire-server-deploy that referenced this pull request Mar 6, 2020
@lucendio
Bump ingress-controller deps to prevent failing helm-upgrade after in…
cc8367b 
…itial install

See helm/charts#20518 for more information
@lucendio lucendio mentioned this pull request Mar 6, 2020
Merged
lucendio added a commit to wireapp/wire-server-deploy that referenced this pull request Mar 6, 2020
@lucendio
Bump ingress-controller deps to prevent failing helm-upgrade after in…
5dd2f20 
…itial install (#194)

See helm/charts#20518 for more information
@lucendio lucendio mentioned this pull request Mar 6, 2020
Merged
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@steved
[stable/nginx-ingress] allow clusterIP values to be set empty (helm#2…
4721c70 
…0518)

Signed-off-by: Steven Davidovitz <steven.davidovitz@dominodatalab.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@taharah taharah Awaiting requested review from taharah

Assignees

@ChiefAlexander ChiefAlexander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@steved @k8s-ci-robot @ChiefAlexander @helm-bot