Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0#20517

Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom
chrisjs:scdf-version-260
Feb 3, 2020
Merged

[stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0#20517
k8s-ci-robot merged 1 commit intohelm:masterfrom
chrisjs:scdf-version-260

Conversation

@chrisjs
Copy link
Copy Markdown
Collaborator

@chrisjs chrisjs commented Feb 3, 2020

What this PR does / why we need it:

  • update scdf version to 2.4.0
  • update skipper version to 2.3.0
  • update chart dependency versions

Signed-off-by: Chris Schaefer cschaefer@pivotal.io

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@chrisjs
[stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0
4491515 
- update scdf version to 2.4.0
- update skipper version to 2.3.0
- update chart dependency versions

Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2020
@chrisjs
Copy link
Copy Markdown
Collaborator Author

chrisjs commented Feb 3, 2020

/assign @sabbyanandan

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
sabbyanandan
sabbyanandan reviewed Feb 3, 2020
View reviewed changes
Comment thread stable/spring-cloud-data-flow/README.md
| Parameter | Description | Default |
| --------------------------- | ------------------------------------------- | ------------------------- |
| rabbitmq.enabled | Enable RabbitMQ as the middleware to use | true
| rabbitmq.rabbitmq.username | RabbitMQ user name | user
Copy link
Copy Markdown
Collaborator

@sabbyanandan sabbyanandan Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing rabbitmq twice looks odd. Could we maybe change it to just rabbitmq.username and rabbitmq.password or is it a breaking change?

Copy link
Copy Markdown
Collaborator Author

@chrisjs chrisjs Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately that wart came as part of upgrading... looks like some props were moved down a level (under rabbitmq block), so in the rabbit yaml itself its for example rabbitmq.username, we have a leading rabbitmq as thats how chart refs are done

sabbyanandan
sabbyanandan approved these changes Feb 3, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sabbyanandan sabbyanandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisjs, sabbyanandan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3e00094 into helm:master Feb 3, 2020
MarcusSorealheis added a commit to MarcusSorealheis/charts that referenced this pull request Feb 4, 2020
@MarcusSorealheis
Merge remote-tracking branch 'upstream/master' into add_superset_main…
51c5fba 
…tainer

* upstream/master: (309 commits)
  [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523)
  [stable/prometheus-redis-exporter] Update image for exporter (helm#19317)
  update alantis version (helm#20507)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517)
  [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409)
  Allow DNS egress to resolve hostnames (helm#20437)
  [stable/rabbitmq] Add PrometheusRule. (helm#20478)
  [stable/drupal] Release 6.2.4 updating components versions (helm#20491)
  [stable/metabase] interpolate liveness and readiness probes (helm#20475)
  [stable/grafana] Fix a typo in the Grafana chart notes (helm#20490)
  [stable/gocd] Quote ingress host (helm#20477)
  [stable/metabase] allow setting jetty options (helm#20456)
  [stable/pgadmin] upgrade to 4.17 and more (helm#20211)
  [stable/prometheus-operator] add apiserverConfig (helm#20453)
  [stable/graylog] Fix helm#20306, add `helm2Compatibility` flag to `values.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464)
  Add annotation support to pushgateway service (helm#20351)
  Upgrade nfs-provisioner to v2.3.0 (helm#20468)
  [stable/sysdig] Upgrade to latest Sysdig Image (9.5.0) (helm#20471)
  [stable/odoo] Update PostgreSQL dependency to latest major (helm#20467)
  [stable/redis] Add PrometheusRule. (helm#20388)
  ...
alexppg pushed a commit to alexppg/charts that referenced this pull request Feb 4, 2020
@chrisjs @alexppg
[stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (hel…
b669ade 
…m#20517)

- update scdf version to 2.4.0
- update skipper version to 2.3.0
- update chart dependency versions

Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>
MarcusSorealheis added a commit to MarcusSorealheis/charts that referenced this pull request Feb 4, 2020
@MarcusSorealheis
Merge branch 'solr_plugin_volume' of github.com:MarcusSorealheis/char…
b4833a0 
…ts into solr_plugin_volume

* 'solr_plugin_volume' of github.com:MarcusSorealheis/charts: (611 commits)
  bump version to be compatible with plugins.
  bump version to be compatible with plugins.
  [stable/kube-state-metrics] Version bump to 1.9.4 (helm#20543)
  [stable/nginx-ingress] allow clusterIP values to be set empty (helm#20518)
  update grafana sidecar to 0.1.75 (helm#20538)
  [stable/mongodb] Release 7.8.2 updating components versions (helm#20537)
  [stable/testlink] add service annotations (helm#20531)
  Rr/strategy (helm#20533)
  [stable/superset] Update Maintainers List (helm#20493)
  [stable/nfs-server-provisioner] New nfs-provisioner with NFSv3 support (helm#19260)
  [stable/pgadmin] removed abundance curly bracket (helm#20530)
  Seq: use deployment strategy (helm#20526)
  [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523)
  [stable/prometheus-redis-exporter] Update image for exporter (helm#19317)
  update alantis version (helm#20507)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517)
  [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409)
  Allow DNS egress to resolve hostnames (helm#20437)
  [stable/rabbitmq] Add PrometheusRule. (helm#20478)
  [stable/drupal] Release 6.2.4 updating components versions (helm#20491)
  ...
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@chrisjs
[stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (hel…
8a13580 
…m#20517)

- update scdf version to 2.4.0
- update skipper version to 2.3.0
- update chart dependency versions

Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maorfr maorfr Awaiting requested review from maorfr

1 more reviewer

@sabbyanandan sabbyanandan sabbyanandan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sabbyanandan sabbyanandan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisjs @k8s-ci-robot @sabbyanandan @helm-bot