Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Rr/strategy#20533

Merged
k8s-ci-robot merged 3 commits intohelm:masterfrom
rowanruseler:rr/strategy
Feb 4, 2020
Merged

Rr/strategy#20533
k8s-ci-robot merged 3 commits intohelm:masterfrom
rowanruseler:rr/strategy

Conversation

@rowanruseler
Copy link
Copy Markdown
Contributor

@rowanruseler rowanruseler commented Feb 4, 2020

Signed-off-by: Rowan Ruseler rowanruseler@gmail.com

@rowanruseler
[stable/pgadmin] added strategy to the deployment
b66e60b 
Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>
@rowanruseler
Merge branch 'master' into rr/strategy
292c8ce 
Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 4, 2020

Hi @rowanruseler. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 4, 2020
@rowanruseler
[stable/pgadmin] removed white-line
9572b4e 
Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>
@paulczar
Copy link
Copy Markdown
Collaborator

paulczar commented Feb 4, 2020

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulczar, rowanruseler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 42d32d2 into helm:master Feb 4, 2020
@rowanruseler rowanruseler mentioned this pull request Feb 4, 2020
Closed
MarcusSorealheis added a commit to MarcusSorealheis/charts that referenced this pull request Feb 4, 2020
@MarcusSorealheis
Merge branch 'solr_plugin_volume' of github.com:MarcusSorealheis/char…
b4833a0 
…ts into solr_plugin_volume

* 'solr_plugin_volume' of github.com:MarcusSorealheis/charts: (611 commits)
  bump version to be compatible with plugins.
  bump version to be compatible with plugins.
  [stable/kube-state-metrics] Version bump to 1.9.4 (helm#20543)
  [stable/nginx-ingress] allow clusterIP values to be set empty (helm#20518)
  update grafana sidecar to 0.1.75 (helm#20538)
  [stable/mongodb] Release 7.8.2 updating components versions (helm#20537)
  [stable/testlink] add service annotations (helm#20531)
  Rr/strategy (helm#20533)
  [stable/superset] Update Maintainers List (helm#20493)
  [stable/nfs-server-provisioner] New nfs-provisioner with NFSv3 support (helm#19260)
  [stable/pgadmin] removed abundance curly bracket (helm#20530)
  Seq: use deployment strategy (helm#20526)
  [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523)
  [stable/prometheus-redis-exporter] Update image for exporter (helm#19317)
  update alantis version (helm#20507)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517)
  [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409)
  Allow DNS egress to resolve hostnames (helm#20437)
  [stable/rabbitmq] Add PrometheusRule. (helm#20478)
  [stable/drupal] Release 6.2.4 updating components versions (helm#20491)
  ...
@rowanruseler rowanruseler deleted the rr/strategy branch February 5, 2020 08:19
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@rowanruseler
Rr/strategy (helm#20533)
4c0c73e 
* [stable/pgadmin] added strategy to the deployment

Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>

* [stable/pgadmin] removed white-line

Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sameersbn sameersbn Awaiting requested review from sameersbn

@scottrigby scottrigby Awaiting requested review from scottrigby

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rowanruseler @k8s-ci-robot @paulczar @helm-bot