Skip to content

Always require OpenSSL#1548

Merged
andrey-kashcheev merged 1 commit into
masterfrom
heresup-1440-cert-path
Oct 2, 2024
Merged

Always require OpenSSL#1548
andrey-kashcheev merged 1 commit into
masterfrom
heresup-1440-cert-path

Conversation

@andrey-kashcheev

@andrey-kashcheev andrey-kashcheev commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

OpenSSL now required, and should be always present
hence OLP_SDK_NETWORK_HAS_OPENSSL could be removed

Relates-To: HERESUP-1440

@codecov

codecov Bot commented Sep 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (17f6a68) to head (82f15a8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
- Coverage   81.44%   81.42%   -0.03%     
==========================================
  Files         345      345              
  Lines       13537    13539       +2     
  Branches     1457     1457              
==========================================
- Hits        11025    11023       -2     
+ Misses       1922     1921       -1     
- Partials      590      595       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrey-kashcheev
andrey-kashcheev force-pushed the heresup-1440-cert-path branch 3 times, most recently from 947b912 to 6e513f9 Compare September 25, 2024 14:15
OpenSSL now required, and should be always present

Relates-To: HERESUP-1440

Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
Comment thread olp-cpp-sdk-core/cmake/curl.cmake
@andrey-kashcheev andrey-kashcheev changed the title Remove OLP_SDK_NETWORK_HAS_OPENSSL Always require OpenSSL Oct 2, 2024
@andrey-kashcheev
andrey-kashcheev merged commit a88a0f2 into master Oct 2, 2024
@andrey-kashcheev
andrey-kashcheev deleted the heresup-1440-cert-path branch October 2, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants