move /usr/local/bin check to after the platform check - #2205
Closed
lonnen wants to merge 2 commits into
Closed
Conversation
`/usr/local/bin` is an os-specific path that must exist on your $PATH. This change moves the check confirming that to _after_ the OS and platform checks to allow for it to bail earlier on windows with a more helpful error message
Contributor
|
This LGTM to me. We should adopt this change. |
Contributor
|
This has been merged in #3179. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/usr/local/binis an os-specific path that must exist on your$PATH. This change moves the check confirming that to after the OS and platform checks to allow for the script to bail earlier on windows with a more helpful error message