Update install-standalone script - #3179
Merged
Merged
Conversation
`/usr/local/bin` is an os-specific path that must exist on your $PATH. This change moves the check confirming that to _after_ the OS and platform checks to allow for it to bail earlier on windows with a more helpful error message
This was referenced Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies two changes from the community:
/usr/local/bincheck to after the platform check #2205 which moves the path check to after the OS checks, as that check only makes sense for specific OSes, and as the author points out, it's certainly more helpful to know when the OS is not supported before knowing if you satisfy the $PATH check