Skip to content

docs: link readme to docs#1059

Merged
phm07 merged 3 commits into
mainfrom
docs-readme
May 23, 2025
Merged

docs: link readme to docs#1059
phm07 merged 3 commits into
mainfrom
docs-readme

Conversation

@phm07

@phm07 phm07 commented May 23, 2025

Copy link
Copy Markdown
Contributor

This PR cleans up the readme, links to the docs where needed and also moves the configuration help text to docs/reference.

@phm07 phm07 self-assigned this May 23, 2025
@phm07 phm07 requested a review from a team as a code owner May 23, 2025 09:25
@codecov

codecov Bot commented May 23, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.30%. Comparing base (5ffbbc5) to head (18a9067).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   70.36%   63.30%   -7.07%     
==========================================
  Files         247      245       -2     
  Lines       10870    10808      -62     
==========================================
- Hits         7649     6842     -807     
- Misses       2544     3244     +700     
- Partials      677      722      +45     
Flag Coverage Δ
e2e ?
unit 63.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread docs/reference/configuration.md Outdated
Comment on lines +24 to +25
to get, list, set and unset configuration options and preferences. You can view a list
of all available options and preferences by running `hcloud config --help`.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to docs/reference/manual/hcloud_config.md#synopsis here? Its now available in the repo directly.

(Also just noticed that the formatting of that page is broken)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense.
About the formatting, we could either wrap the table in a code block or change the table formatting to a markdown compatible format (making the CLI help output less pretty though). Which option do you prefer?

Comment thread README.md Outdated
You can download pre-built binaries for Linux, FreeBSD, macOS, and Windows on
the [releases page](https://github.com/hetznercloud/cli/releases).
- See [setting up hcloud](docs/tutorials/setup-hcloud-cli.md) for instructions on how to install and configure the CLI.
- See the [manual](docs/reference/manual) for a list of all available commands and their options.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about linking to the docs/reference/manual/hcloud.md instead? It feels nicer than the huge list of commands.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sorry, wasn't thinking :D

@phm07 phm07 merged commit 89b2a6a into main May 23, 2025
@phm07 phm07 deleted the docs-readme branch May 23, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants