Fix reported interface and sound issues#2330
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix nine reported usability and gameplay issues across authentication, settings, the lobby, profiles, and the game room.
:)and:(to the correct emoji search resultsRoot causes
Several components combined Bootstrap fixed/minimum widths with mobile layouts, the Join Game sizing class was attached to the modal content while its CSS targeted the dialog, and native/custom dropdown states did not consistently inherit dark-theme colors. Sound settings were captured once when the module loaded, so later saves could not affect playback. Emoji lookup searched punctuation directly and returned ambiguous fuzzy matches.
Validation
make test— 1,350 tests passed; 9 skipped; 45 excludedmix credo --strictmix dialyzermix format --check-formattedpnpm run checkpnpm run test— 100 tests passedpnpm run buildFixes #2313
Fixes #2304
Fixes #2302
Fixes #2301
Fixes #2294
Fixes #2291
Fixes #2288
Fixes #2285
Fixes #2281