Skip to content

docs(core): fix frame adapter reference links - #1942

Closed
tianma-if wants to merge 1 commit into
heygen-com:mainfrom
tianma-if:codex/core-docs-frame-links
Closed

docs(core): fix frame adapter reference links#1942
tianma-if wants to merge 1 commit into
heygen-com:mainfrom
tianma-if:codex/core-docs-frame-links

Conversation

@tianma-if

Copy link
Copy Markdown
Contributor

What changed

  • Replaces two stale links in packages/core/docs/core.md with existing concept docs for frame adapters and deterministic rendering.

Why

  • The old links pointed at files that are no longer present in the repository, so readers landed on broken references.

Validation

  • Ran a local relative-link check for packages/core/docs/core.md.

@tianma-if
tianma-if marked this pull request as ready for review July 5, 2026 08:08
@tianma-if

Copy link
Copy Markdown
Contributor Author

Ready for review. This PR is mergeable, kept to a small single-purpose change, and maintainer edits are enabled. Happy to adjust anything you prefer before merge.

@miguel-heygen

Copy link
Copy Markdown
Collaborator

Closing in the backlog value sweep. This is documentation, test-only, dependency upkeep, refactoring, or narrow diagnostic/ergonomic polish without enough current user impact or an active merge path to justify carrying it open. Please reopen or resubmit against current main if the need is still concrete.

@tianma-if

Copy link
Copy Markdown
Contributor Author

Refreshed this fix onto current main and revalidated both replacement targets (docs/concepts/frame-adapters.mdx and docs/concepts/determinism.mdx). Formatting and git diff --check pass; CI is rerunning.

@jrusso1020

Copy link
Copy Markdown
Collaborator

Closing now that the refreshed, attributed successor #3667 has merged with Magi approval and passing checks. The fix was verified against current implementation and usage. Thanks for the original contribution.

@jrusso1020 jrusso1020 closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants