docs(core): fix published frame adapter reference links - #3667
Merged
Conversation
miguel-heygen
approved these changes
Sep 4, 2026
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 29781e19d5b8d1ebfbd6ce021a121de5b3a94826. No findings.
packages/core/docs/core.md:7 now links to the public frame adapters and determinism pages. Both resolve to the intended documentation. The package publishes docs, so absolute URLs also avoid escaping an installed package directory.
Validation: full one-line diff, package file inclusion, and both live destinations checked. No prior reviews or comments; CI had no observed failures, with jobs still running. This is a documentation review; no runtime behavior claims.
Verdict: APPROVE
Reasoning: Both replacements are relevant, reachable, and valid outside a repository checkout. Pending CI must complete before merge.
— Magi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core schema reference links to two documents that no longer exist. Point readers to the current frame adapter and determinism concept pages using public URLs, which also work from the published core package.
Successor to #1942 by @tianma-if; original authorship preserved. The proposed repository-relative replacements would escape the installed package.
Validation: both public pages resolve; package contents and adjacent local links checked; whitespace and all applicable commit hooks pass. The repository formatter skips this file.