Skip to content

docs(core): fix published frame adapter reference links - #3667

Merged
jrusso1020 merged 1 commit into
mainfrom
refresh/core-reference-links-1942
Sep 4, 2026
Merged

docs(core): fix published frame adapter reference links#3667
jrusso1020 merged 1 commit into
mainfrom
refresh/core-reference-links-1942

Conversation

@jrusso1020

Copy link
Copy Markdown
Collaborator

The core schema reference links to two documents that no longer exist. Point readers to the current frame adapter and determinism concept pages using public URLs, which also work from the published core package.

Successor to #1942 by @tianma-if; original authorship preserved. The proposed repository-relative replacements would escape the installed package.

Validation: both public pages resolve; package contents and adjacent local links checked; whitespace and all applicable commit hooks pass. The repository formatter skips this file.

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 29781e19d5b8d1ebfbd6ce021a121de5b3a94826. No findings.

packages/core/docs/core.md:7 now links to the public frame adapters and determinism pages. Both resolve to the intended documentation. The package publishes docs, so absolute URLs also avoid escaping an installed package directory.

Validation: full one-line diff, package file inclusion, and both live destinations checked. No prior reviews or comments; CI had no observed failures, with jobs still running. This is a documentation review; no runtime behavior claims.

Verdict: APPROVE
Reasoning: Both replacements are relevant, reachable, and valid outside a repository checkout. Pending CI must complete before merge.

— Magi

@jrusso1020
jrusso1020 merged commit 8931414 into main Sep 4, 2026
59 checks passed
@jrusso1020
jrusso1020 deleted the refresh/core-reference-links-1942 branch September 4, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants