Skip to content

Add option to repeatedly output status information#633

Open
602p wants to merge 7 commits intohirschmann:betafrom
602p:master
Open

Add option to repeatedly output status information#633
602p wants to merge 7 commits intohirschmann:betafrom
602p:master

Conversation

@602p
Copy link
Copy Markdown

@602p 602p commented Feb 5, 2019

This patch introduces a -p option to the status verb of the cli tool that causes the status to be repeatedly output. The rate is configurable as an optional argument to the parameter (measured in seconds, supporting float values.)

The rationale behind this patch is that I like to have a display of the current (target) fan speed in my system bar, and the CPU overhead from repeated mono startup was a major contributor to load on an otherwise idle system. Keeping a copy of the cli tool running in the background avoids that. I use this as an i3blocks element by running nbfc status -p 1 -f 0 | awk '/Target/ { printf("%3d\n", $5); system("") }' with interval=persist.

If this is merged, we should be sure to update the CLI examples page on the Wiki.

tobiashein and others added 7 commits November 10, 2018 13:22
I see that my e580 seems to behave in the same way, and I think this is a bug:
Author of this config probably wanted to set 80 as hex not as decimal.

on my device this is what happens on exit:
hex 80 = dec 128 => factory auto mode
hex 50 = dec 80   => full speed of fan
This configuration is an exact copy of "Asus ROG G752VT" as it also 
works here.

In case it turns out to be important in the future: this is for a ROG 
G752VS 7th Gen
(since there may also be versions with 6th Gen Intel processors).
@602p 602p changed the base branch from master to beta February 5, 2019 01:50
@602p
Copy link
Copy Markdown
Author

602p commented Feb 5, 2019

Looks like I made this PR against master instead of beta. Sorry about that. I changed it in the GitHub interface, but let me know if I should instead close and reopen one with this change rebased against beta.

@hirschmann
Copy link
Copy Markdown
Owner

Thank you very much for your contribution!
Sorry it took me so long to respond. I was quite busy in the last couple of months :/

Master is actually meant to be the public integration branch for this repository, so it was perfectly fine to base your patch on master.

I'm planning to create a REST API for the service to make it easier to access from other scripts/programs.
This means the CLI tool will not be required to poll the service in the future. Therefore I'm not gonna merge this PR (sorry!), but I'm leaving it open so that it's easier to find for others which may find it useful.

@adolfo00000
Copy link
Copy Markdown

hey what about if you add a fan overcloking feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants