S28 5057/rtmps link suffix

[lydiaralphgov]

Important

This PR requires small changes on Power Automate, sds-flux-config and CVP before it will work

JIRA ticket(s)

• S28-5057

Change description

• Adds a suffix to the RTMPS link returned to Power Platform
• This means that the court clerk will not need to manually enter reference details

CVP change

This reference details box needs to be turned off in rooms which are being used for recordings on environments where this new code is deployed.

To make it ready for testing

• Get sds-flux-config PR ready: Turn on RTMPS suffix in Demo sds-flux-config#8662
• Merge code into Demo API
• Alter Power Automate flow:

1. https://make.powerautomate.com
2. App_API_AMS_CreateAndStartLiveEvent
3. Find the step called "Set variable - rtmpAddress" near the bottom
4. Change it from body/input_rtmp to body/displayed_rtmps_link

QA instructions

Test 1: Demo is not broken when flag is false and CVP is unchanged

1. Ask CVP to enable CVP reference details box
2. Ensure the RTMPS_SUFFIX_ENABLED flag is false on Demo (i.e. don't merge the flux config PR yet)
3. Schedule a recording as normal
4. Click 'Start recording'
5. Assert that the RTMPS link does not have a suffix (i.e. has not changed)
6. Copy and paste the RTMPS link into the CVP room as normal (with the CVP change not implemented)
7. Assert that the recording is successful

Test 2: Demo is not broken when flag is true and CVP have turned off reference details box

1. Ask CVP to disable CVP reference details box
2. Ensure the RTMPS_SUFFIX_ENABLED flag is true on Demo (i.e. merge the flux config PR)
3. Schedule a recording as normal
4. Click 'Start recording'
5. Assert no CVP reference details box appears
6. Assert that the RTMPS link does have a suffix (i.e. has changed)
7. Copy and paste the RTMPS link into the CVP room as normal
8. Assert that the recording is successful

Test 3: RTMPS link continues to have suffix when the user re-requests the RTMPS link

1. After starting a recording, navigate back to the Live Screen view
2. Click 'Show Link'
3. The RTMPS link should match the previous RTMPS link from when the recording was first started

Release instructions

1. Merge code into master branch and promote to prod: this is not a breaking change
2. Alter Power Automate flow on all envs: this is not a breaking change and can be done after step 1
3. Ask CVP to turn off the reference details box on all CVP rooms - this is a breaking change
4. Enable the RTMPS_SUFFIX_ENABLED flag - must be done straight after the CVP change

[github-actions]

‼️ Change to API Spec detected

Monitor carefully when deploying to production.

Follow the release process and manually check that the Streaming Manager and portal are healthy after the release.

See https://tools.hmcts.net/confluence/spaces/S28/pages/1958069495/API+release+process for details.

[oliver-scott]

looks good, just a suggestion around testing

[oliver-scott]

might be worth double checking the RTMPS link works with special characters in the case reference - if not then maybe we could simplify this