S28 5057/rtmps link suffix#1511
Merged
Merged
Conversation
… into S28-5057/rtmps-link-suffix
|
Monitor carefully when deploying to production. Follow the release process and manually check that the Streaming Manager and portal are healthy after the release. See https://tools.hmcts.net/confluence/spaces/S28/pages/1958069495/API+release+process for details. |
lydiaralphgov
commented
Jul 8, 2026
| Long.parseUnsignedLong(liveEventId.substring(16), 16) | ||
| ); | ||
| return this.findById(liveEventUUID); | ||
| return captureSessionRepository |
Contributor
Author
There was a problem hiding this comment.
This changed because of code checker complaints
| .andReturn().getResponse(); | ||
|
|
||
| assertThat(response.getContentAsString()).isEqualTo("successfully connected to media service (MediaKind)"); | ||
| assertThat(response.getContentAsString()) |
Contributor
Author
There was a problem hiding this comment.
Lots of new line breaks in this file due to code checker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opened #1507 after demo was overwritten by merge to master.
Important
This PR requires small changes on Power Automate, sds-flux-config and CVP before it will work
JIRA ticket(s)
Change description
CVP change
This reference details box needs to be turned off in rooms which are being used for recordings on environments where this new code is deployed.
To make it ready for testing
displayed_rtmps_linkin LiveEventDTObody/input_rtmptobody/displayed_rtmps_linkQA instructions
Test 1: Demo is not broken when flag is false and CVP is unchanged
RTMPS_SUFFIX_ENABLEDflag is false on Demo (i.e. don't merge the flux config PR yet)Test 2: Demo is not broken when flag is true and CVP have turned off reference details box
RTMPS_SUFFIX_ENABLEDflag is true on Demo (i.e. merge the flux config PR)Test 3: RTMPS link continues to have suffix when the user re-requests the RTMPS link
Release instructions
RTMPS_SUFFIX_ENABLEDflag - must be done straight after the CVP change