Fix coverage crash & update contributing documentation #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that they were running in the wrong order, which caused problems where some tests depended on other tests that hadn't run yet. I therefore added copied '-S' flag from the test script to the coverage script.
This location was changed by c2a511a Fixing up the contributing doc (which changed the generator from the html-cov reporter to Istanbul), but the docs weren't updated at the time.
pmcnr-hx
approved these changes
May 1, 2017
Contributor
pmcnr-hx
left a comment
pmcnr-hx
left a comment
There was a problem hiding this comment.
Thank your for the contribution. Looks good. Merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash when running
npm run coverage, and also updates the documentation on where to find coverage reports.