Skip to content

Fix coverage crash & update contributing documentation #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2017
Merged

Fix coverage crash & update contributing documentation #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7044daa
Fix tests failing during `npm run coverage`
wolfgang42 Mar 2, 2017
f51af04
Update documentation on where to find the coverage reports.
wolfgang42 Mar 2, 2017
e65dc79
Merge branch 'master' into fix-coverage
pmcnr-hx May 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ npm test
To check the code coverage is still great:
```
npm run coverage
google-chrome ./coverage.html
google-chrome ./coverage/lcov-report/index.html
```

To see code complexity statistics:
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"scripts": {
"test": "node ./node_modules/mocha/bin/mocha --require use-strict -S -R spec ./test/*.js",
"start": "node example/server.js",
"coverage": "istanbul cover ./node_modules/mocha/bin/_mocha -- -R spec",
"coverage": "istanbul cover ./node_modules/mocha/bin/_mocha -- -S -R spec",
"complexity": "node ./node_modules/plato/bin/plato -r -d complexity lib",
"performance": "node --allow-natives-syntax --harmony ./node_modules/mocha/bin/_mocha -S --reporter mocha-performance ./test/*.js",
"lint": "node ./node_modules/eslint/bin/eslint ./example ./lib ./test --quiet && echo '✔ All good!'",
Expand Down