Pre-stage :vn alongside :vi in lunar calendar map (#177)#472
Merged
Conversation
Signed-off-by: Phil Peble <phil@peble.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for the Vietnam region code rename
:vi->:vn(definitions #177).Adds
vn: VIETNAMESE_LUNAR_YEAR_INFOalongside the existingvi:key inCALENDAR_YEAR_INFO_MAP. This is non-breaking and inert today (novnregion exists yet), but it lets the lunarlunar_to_solarcalculation resolve once the definitions repo renames Vietnam tovn.Why now: the definitions PR holidays/definitions#341 renames
vi.yaml->vn.yaml, and its downstream contract test (which clones this repo's master) fails until master knows:vn. Merging this unblocks that check.The legacy
:vikey is removed later in the breaking major release that bumps the definitions submodule.Test added:
to_solar(..., :vn)resolves the Hung Kings Festival dates identically to:vi.