Use an animated Home Assistant icon in LoadingScreen instead of HaLoader - #7244
Conversation
Test Results 329 files 359 suites 14m 18s ⏱️ Results for commit 79ae005. ♻️ This comment has been updated with latest results. |
|
@marcinbauer-ohf would you mind tell us if it's ok to merge this or we should wait? |
There was a problem hiding this comment.
Pull request overview
This PR updates the app’s Compose LoadingScreen to replace the HALoading indicator with a lightweight, Compose-drawn pulse animation over the Home Assistant launch icon’s three dots, aligning the loading experience more closely with the frontend/splash branding.
Changes:
- Removed
HALoadingfromLoadingScreenand introduced an infinite pulse animation rendered viadrawWithContent. - Adjusted layout logic to only offset the icon to make room for the optional OHF branding (no longer accounting for a separate spinner).
- Improved accessibility by assigning
loading_content_descriptionto the icon.
|
Thanks @TimoPtr. We also need to change the OHF logo shown below, and add a translatable string (#3 OpenHomeFoundation/ux-design#24 (comment)): EDIT: use the icons from https://github.com/OpenHomeFoundation/brand-assets/ |
|
I see
with different styles from what ended up in the app (according to screenshot tests). Did you change this in later discussions outside the PR or does this still need to be changed? |
Sorry I didn't update, but yes we talk outside of the PR and agreed to use the icon from the branding repository https://github.com/OpenHomeFoundation/brand-assets/ |
OK, but I see the updated frontend loading screen PR didn't adjust and neither did iOS (unless I'm missing PRs). Now it'd be even more inconsistent than before. |
pinging them 👍🏻 |
|
@TimoPtr I've changed the scaling animation of the dots from 1.2 to 1.3 to make it pop a bit more. The attached asset has this change. |
|
Which OHF logo to use is still a bit confusing to me. You said there was additional discussion, but OpenHomeFoundation/ux-design#24 (comment) suggests it wasn't available and now it's hosted, yet the file you use/link has been there for months. |
I guess the information was not properly spread that the assets where in the repo. |
|
One last change it should have been the monochrome icon and not the colored one. |
8e76b61 to
761f294
Compare
jpelgrom
left a comment
There was a problem hiding this comment.
This looks like frontend and related discussions now so merging it
Summary
Part of OpenHomeFoundation/ux-design#24, this PR replaces the HaLoading within the LoadingScreen with a small animation on top of the SVG. I kept it simple by simply drawing circle and scale them in compose instead of using an animated vector drawable.
Checklist
Select exactly one option that describes AI usage in this contribution:
Screenshots
Screen_recording_20260728_130404.mp4