Skip to content

Use an animated Home Assistant icon in LoadingScreen instead of HaLoader - #7244

Merged
jpelgrom merged 8 commits into
mainfrom
feature/animated_loading
Jul 30, 2026
Merged

Use an animated Home Assistant icon in LoadingScreen instead of HaLoader#7244
jpelgrom merged 8 commits into
mainfrom
feature/animated_loading

Conversation

@TimoPtr

@TimoPtr TimoPtr commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

Part of OpenHomeFoundation/ux-design#24, this PR replaces the HaLoading within the LoadingScreen with a small animation on top of the SVG. I kept it simple by simply drawing circle and scale them in compose instead of using an animated vector drawable.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.
  • I have read the Open Home Foundation AI Policy.

Select exactly one option that describes AI usage in this contribution:

  • I have not used AI for this contribution.
  • AI assistance was used for this contribution.
  • AI fully generated the code for this contribution, but I've reviewed and understood it before submitting and will respond without AI during review.

Screenshots

Screen_recording_20260728_130404.mp4

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Test Results

  329 files    359 suites   14m 18s ⏱️
2 857 tests 2 856 ✅ 1 💤 0 ❌
3 025 runs  3 024 ✅ 1 💤 0 ❌

Results for commit 79ae005.

♻️ This comment has been updated with latest results.

@TimoPtr

TimoPtr commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

@marcinbauer-ohf would you mind tell us if it's ok to merge this or we should wait?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the app’s Compose LoadingScreen to replace the HALoading indicator with a lightweight, Compose-drawn pulse animation over the Home Assistant launch icon’s three dots, aligning the loading experience more closely with the frontend/splash branding.

Changes:

  • Removed HALoading from LoadingScreen and introduced an infinite pulse animation rendered via drawWithContent.
  • Adjusted layout logic to only offset the icon to make room for the optional OHF branding (no longer accounting for a separate spinner).
  • Improved accessibility by assigning loading_content_description to the icon.

Comment thread app/src/main/kotlin/io/homeassistant/companion/android/loading/LoadingScreen.kt Outdated
@marcinbauer-ohf

marcinbauer-ohf commented Jul 27, 2026

Copy link
Copy Markdown
Member

Thanks @TimoPtr. We also need to change the OHF logo shown below, and add a translatable string (#3 OpenHomeFoundation/ux-design#24 (comment)):
Splash screen should start with the HA logo, and the OHF logo below, then just animate the HA logo in the center of the screen. Please see iOS implementation for reference: home-assistant/iOS#5218

EDIT: use the icons from https://github.com/OpenHomeFoundation/brand-assets/

Comment thread common/src/main/res/drawable-night/ohf_lockup_inline.xml Fixed
Comment thread common/src/main/res/drawable/ohf_lockup_inline.xml Fixed
@jpelgrom

Copy link
Copy Markdown
Member

I see

I'm attaching the correct SVGs for the OHF logo.

with different styles from what ended up in the app (according to screenshot tests). Did you change this in later discussions outside the PR or does this still need to be changed?

Comment thread common/src/main/res/values/strings.xml Outdated
@TimoPtr

TimoPtr commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

I see

I'm attaching the correct SVGs for the OHF logo.

with different styles from what ended up in the app (according to screenshot tests). Did you change this in later discussions outside the PR or does this still need to be changed?

Sorry I didn't update, but yes we talk outside of the PR and agreed to use the icon from the branding repository https://github.com/OpenHomeFoundation/brand-assets/

@jpelgrom

jpelgrom commented Jul 28, 2026

Copy link
Copy Markdown
Member

Sorry I didn't update, but yes we talk outside of the PR and agreed to use the icon from the branding repository https://github.com/OpenHomeFoundation/brand-assets/

OK, but I see the updated frontend loading screen PR didn't adjust and neither did iOS (unless I'm missing PRs). Now it'd be even more inconsistent than before.

@TimoPtr

TimoPtr commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

Sorry I didn't update, but yes we talk outside of the PR and agreed to use the icon from the branding repository OpenHomeFoundation/brand-assets

OK, but I see the updated frontend loading screen PR didn't adjust and neither did iOS (unless I'm missing PRs). Now it'd be even more inconsistent than before.

pinging them 👍🏻

@marcinbauer-ohf

Copy link
Copy Markdown
Member

@TimoPtr I've changed the scaling animation of the dots from 1.2 to 1.3 to make it pop a bit more. The attached asset has this change.
ha-loading-anim

Comment thread app/src/main/kotlin/io/homeassistant/companion/android/loading/LoadingScreen.kt Outdated
@TimoPtr
TimoPtr requested a review from jpelgrom July 28, 2026 08:48
@jpelgrom

Copy link
Copy Markdown
Member

Which OHF logo to use is still a bit confusing to me. You said there was additional discussion, but OpenHomeFoundation/ux-design#24 (comment) suggests it wasn't available and now it's hosted, yet the file you use/link has been there for months.

@TimoPtr

TimoPtr commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

Which OHF logo to use is still a bit confusing to me. You said there was additional discussion, but OpenHomeFoundation/ux-design#24 (comment) suggests it wasn't available and now it's hosted, yet the file you use/link has been there for months.

I guess the information was not properly spread that the assets where in the repo.

@TimoPtr

TimoPtr commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

One last change it should have been the monochrome icon and not the colored one.

Base automatically changed from feature/hide_frontend_loading_screen to main July 29, 2026 08:48
@TimoPtr
TimoPtr force-pushed the feature/animated_loading branch from 8e76b61 to 761f294 Compare July 29, 2026 08:50

@jpelgrom jpelgrom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like frontend and related discussions now so merging it

@jpelgrom
jpelgrom merged commit 1a294b0 into main Jul 30, 2026
50 of 54 checks passed
@jpelgrom
jpelgrom deleted the feature/animated_loading branch July 30, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants